Project

General

Profile

Actions
Copy link

Bug #46985

closed

common: validate type CephBool cause 'invalid command json'

Added by Yanhu Cao over 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Yanhu Cao
Category:
-
Target version:
Ceph - v16.0.0
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
octopus,nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
36459
Crash signature (v1):
Crash signature (v2):

Description

  while (!validate_cmd(m_cct, p->second.desc, cmdmap, errss)) {
    ++p;
    if (p->first != prefix) {
      delete f;
      return on_finish(-EINVAL, "invalid command json", empty);
    }
  }

don't need to check prefix in while loop because previous already done.

Related issues 3 (0 open — 3 closed)

Related to rgw - Bug #47179: AdminSocket::do_accept() terminate called after throwing an instance of 'std::out_of_range'ResolvedBrad Hubbard

Actions
Copied to CephFS - Backport #47085: octopus: common: validate type CephBool cause 'invalid command json'ResolvedNathan CutlerActions
Copied to CephFS - Backport #47086: nautilus: common: validate type CephBool cause 'invalid command json'RejectedActions
Actions
Copy link
 #1

Updated by Nathan Cutler over 3 years ago

  • Project changed from Ceph to CephFS
  • Status changed from New to Fix Under Review
  • Pull request ID set to 36459
Actions
Copy link
 #2

Updated by Patrick Donnelly over 3 years ago

  • Assignee set to Yanhu Cao
  • Target version set to v16.0.0
  • Source set to Community (dev)
  • Backport set to octopus,nautilus

Just this commit needs backported:

common: fix validate type CephBool cause 'invalid command json'

Fixes: https://tracker.ceph.com/issues/46985
Signed-off-by: Yanhu Cao <>

Actions
Copy link
 #3

Updated by Patrick Donnelly over 3 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #4

Updated by Nathan Cutler over 3 years ago

  • Copied to Backport #47085: octopus: common: validate type CephBool cause 'invalid command json' added
Actions
Copy link
 #5

Updated by Nathan Cutler over 3 years ago

  • Copied to Backport #47086: nautilus: common: validate type CephBool cause 'invalid command json' added
Actions
Copy link
 #6

Updated by Brad Hubbard over 3 years ago

  • Related to Bug #47179: AdminSocket::do_accept() terminate called after throwing an instance of 'std::out_of_range' added
Actions
Copy link
 #7

Updated by Brad Hubbard over 3 years ago

This change causes the failure seen in #47179. Could we either revert it or modify it so it reinstates the old behaviour?

Actions
Copy link
 #9

Updated by Nathan Cutler over 3 years ago

Neha Ojha wrote:

https://github.com/ceph/ceph/pull/37098 fixes a bug in https://github.com/ceph/ceph/pull/36459 and needs backport too.

That's #47179 which has already been backported to octopus by https://github.com/ceph/ceph/pull/37341

Actions
Copy link
 #10

Updated by Loïc Dachary about 3 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link

Also available in: Atom PDF