Actions
Fix #4635
closedmon: many ops expose uncommitted state
Status:
Resolved
Priority:
High
Assignee:
Category:
Monitor
Target version:
% Done:
0%
Source:
Q/A
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
The prepare_update() methods are tricky because they need to make changes relative to uncommitted (pending) state. If they are a noop based on that state, they need to still wait for a commit, even though they aren't making an additional change. This isn't handled correctly in many of the OSDMonitor CLI commands... osd rm, osd crush rm to name just two.
A simple pattern that might make it easy to catch this is for a r=0 value at the end of the function to wait for a commit.
Actions