Actions
Bug #42923
closedpybind / cephfs: remove static typing in LibCephFS.chown
Status:
Resolved
Priority:
Normal
Assignee:
Category:
Code Hygiene
Target version:
% Done:
0%
Source:
Community (dev)
Tags:
Backport:
nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
mgr/volumes
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
def chown(self, path, int uid, int gid): """ Change directory ownership :param path: the path of the directory to change. :param uid: the uid to set :param gid: the gid to set """ self.require_state("mounted") path = cstr(path, 'path') if not isinstance(uid, int): raise TypeError('uid must be an int') elif not isinstance(gid, int): raise TypeError('gid must be an int')
although Cython supports typing function agrs, it makes less sense as the type is checked in the function itself. Plus, to be uniform with other cephfs python binding APIs, it makes sense to remove static typing here.
Actions