Bug #40429
closed
mgr/volumes: subvolume.py calls Exceptions with too few arguments.
Added by Sebastian Wagner almost 5 years ago.
Updated almost 5 years ago.
Component(FS):
mgr/volumes
Description
mypy revealed
+pybind/mgr/volumes/fs/subvolume.py: note: In member "get_subvolume_path" of class "SubVolume":
+pybind/mgr/volumes/fs/subvolume.py:167: error: Too few arguments for "VolumeException"
+pybind/mgr/volumes/fs/subvolume.py: note: In member "_get_ancestor_xattr" of class "SubVolume":
+pybind/mgr/volumes/fs/subvolume.py:203: error: Too few arguments for "NoData"
both of these errors are actual bugs in the code and needs to get fixed.
- Project changed from mgr to CephFS
- Component(FS) mgr/volumes added
- Priority changed from Normal to Urgent
- Target version set to v15.0.0
- Start date deleted (
06/19/2019)
- Pull request ID set to 28706
- Status changed from New to Fix Under Review
+pybind/mgr/volumes/fs/subvolume.py: note: In member "_get_ancestor_xattr" of class "SubVolume":
+pybind/mgr/volumes/fs/subvolume.py:203: error: Too few arguments for "NoData"
I don't get the above error, when I run `./script/run_mypy.sh` against ceph master.
Ramana Raja wrote:
+pybind/mgr/volumes/fs/subvolume.py: note: In member "_get_ancestor_xattr" of class "SubVolume":
+pybind/mgr/volumes/fs/subvolume.py:203: error: Too few arguments for "NoData"
I don't get the above error, when I run `./script/run_mypy.sh` against ceph master.
That's because mypy cannot inspect cython bindings without type hints added in
https://github.com/ceph/ceph/pull/26769/files#diff-c1f4bb1fdcc925889b5d9e38148ee07eR16
- Status changed from Fix Under Review to Pending Backport
- Copied to Backport #40569: nautilus: mgr/volumes: subvolume.py calls Exceptions with too few arguments added
- Status changed from Pending Backport to Resolved
Also available in: Atom
PDF