Project

General

Profile

Bug #39533

mgr/dashboard: notify the user about unset 'mon_allow_pool_delete' flag beforehand

Added by Tatjana Dehler about 2 months ago. Updated 8 days ago.

Status:
Need Review
Priority:
Normal
Category:
dashboard/usability
Target version:
-
Start date:
04/30/2019
Due date:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Screenshot_2019-04-30_12-00-31.png View - pool deletion dialog (45.3 KB) Tatjana Dehler, 04/30/2019 10:05 AM

History

#1 Updated by Tatjana Dehler about 2 months ago

  • File Screenshot_2019-04-30_12-00-31.png View added
  • Subject changed from mgr/dashboard: to mgr/dashboard: notify the user about unset 'mon_allow_pool_delete' flag beforehand
  • Category set to dashboard/usability
  • Assignee set to Tatjana Dehler
  • Source set to Development

If the 'mon_allow_pool_delete' flag is not set and the user tries to delete a pool, he only gets notified about it, when he checks "Yes, I am sure." and clicks the "Delete Pool" button in the deletion dialog (see attachment). It would be good to let him know he currently can't delete pools beforehand.

There are to possible options:

1. Deactivate the "Delete" button in the menu and show a tooltip containing the reason why it's not possible to delete pools. It's the favored solution (as discussed in the dashboard stand-up) but needs some investigation if it's possible to show a tooltip for deactivated components.
2. If option 1.) is not possible a modal dialog, containing the reason why deleting pools is not possible, should be shown after clicking "Delete" in the menu.

#2 Updated by Sebastian Wagner about 2 months ago

Option 3: Fix mon_allow_pool_delete : This flag was never meant to introduce Dashboard bugs.
Option 4: Remove mon_allow_pool_delete altogether and replace it with something more suitable for CLI users.

Relates to https://github.com/ceph/ceph/pull/11665

#3 Updated by Wido den Hollander about 2 months ago

I would be very, very cautious with this. Removing pools should not be very easy for users.

The mon_allow_pool_delete was introduced as users would remove pools by accident. Keep in mind that there are also APIs which do not ask and just do what you want them to do. You can remove a 1PB pool without the API asking twice. We do not want that to happen.

Only if we have a soft-delete or a grace period when removing a pool this might be an option. Otherwise I would always make it very difficult to remove pools.

#4 Updated by Lenz Grimmer about 2 months ago

Wido den Hollander wrote:

I would be very, very cautious with this. Removing pools should not be very easy for users.

The mon_allow_pool_delete was introduced as users would remove pools by accident. Keep in mind that there are also APIs which do not ask and just do what you want them to do. You can remove a 1PB pool without the API asking twice. We do not want that to happen.

Only if we have a soft-delete or a grace period when removing a pool this might be an option. Otherwise I would always make it very difficult to remove pools.

Thanks for your feedback, Wido!

Note that this issue is primarily about making the user aware of the fact that mon_allow_pool_delete is set to false and that the delete operation will not succeed.

This provides a better user experience than letting the user proceed with the pool deletion workflow and then getting an error from the backend, that the deletion operation failed.

#5 Updated by Tatjana Dehler 23 days ago

  • Status changed from New to In Progress

#6 Updated by Tatjana Dehler 23 days ago

  • Pull request ID set to 28260

#7 Updated by Ricardo Marques 8 days ago

  • Status changed from In Progress to Need Review

Also available in: Atom PDF