Bug #37834
closed
- Assignee set to Tiago Melo
- Pull request ID set to 25656
- Status changed from New to Fix Under Review
FYI: Ernesto run a quick check on the impact of this issue (https://github.com/twbs/bootstrap/pull/26630) to the dashboard codebase, and currently we are not using any of the vulnerable properties (data-parent, data-target or data-container).
$ egrep "data-(parent|target|container)" src/pybind/mgr/dashboard/frontend -RI --include="*.html" --include="*.ts"
However, I suggest to update the Boostrap library anyway, just in case we ever plan to use any of these properties.
- Status changed from Fix Under Review to Pending Backport
- Target version changed from v14.0.0 to v15.0.0
- Backport changed from mimic to nautilus
- Copied to Backport #38986: nautilus: mgr/dashboard: Update Bootstrap to 3.4.0 added
- Status changed from Pending Backport to Resolved
- Backport deleted (
nautilus)
- Target version deleted (
v15.0.0)
Ricardo M. writes: "These changes are already included in nautilus, we don't need to create a backport PR"
- Tracker changed from Fix to Bug
- Project changed from mgr to Dashboard
- Category changed from 132 to General
- Regression set to No
- Severity set to 3 - minor
Also available in: Atom
PDF