Project

General

Profile

Actions
Copy link

Feature #313

closed

Support loglevel

Added by Wido den Hollander almost 14 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Like spoken about yesterday, it would be usefull if we could set a loglevel for the RADOS Gateway.

We would use the Ceph configuration for this, but since we are in a CGI envirioment, i would advise using a env variable configured in Apache.

Something like:

SetEnv RADOS_LOG_LEVEL 1|2|3

We would then classify every message under which loglevel it should be.

Just did a small performance test, removing ALL the output to Apache's error_log gave ma a 250% performance boost (from 140 req/sec to ~ 400 req/sec

For some debugging the error_log output is nice, but to much logging will kill your performance.

Files

Download all files
support_log_level.patch (22.5 KB) support_log_level.patch Wido den Hollander, 07/28/2010 09:54 AM
0001-rgw-Support-a-loglevel-of-0.patch (750 Bytes) 0001-rgw-Support-a-loglevel-of-0.patch Support a loglevel of 0 Wido den Hollander, 07/29/2010 04:57 AM
Actions
Copy link
 #1

Updated by Wido den Hollander almost 14 years ago

I gave this some work today and created a patch, see the attachment.

The gateway will read the evirionment variable "RGW_LOG_LEVEL".

In rgw_common.h I added a marco which redirects the messages to the webservers logfile (if the loglevel is high enough)

There is some more work classifying the messages and making them output more understandable messages.

Actions
Copy link
 #2

Updated by Wido den Hollander over 13 years ago

One small glitch in the patch, setting a loglevel of 0 was not supported due to a wrong if-condition.

Attached a patch to fix this

Actions
Copy link
 #3

Updated by Yehuda Sadeh over 13 years ago

  • Status changed from New to Resolved

both patches were merged in, commit:801150a723aaaba2f53995f1646abb9fabc37df5 and commit:840530e42a7adeb8045777d6cc4dbfb29344815e.

Actions
Copy link
 #4

Updated by Sage Weil about 13 years ago

  • Category set to radosgw
Actions
Copy link
 #5

Updated by Sage Weil about 13 years ago

  • Project changed from 4 to Ceph
  • Category changed from radosgw to 22
Actions
Copy link
 #6

Updated by John Spray over 6 years ago

  • Project changed from Ceph to rgw
  • Category deleted (22)

Bulk reassign of radosgw category to RGW project.

Actions
Copy link

Also available in: Atom PDF