Project

General

Profile

Actions

Bug #16230

closed

rbd-mirror: potential race condition accessing local image journal

Added by Jason Dillaman almost 8 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
High
Assignee:
Jason Dillaman
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
jewel
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

If the image watch is lost, the exclusive lock will be released and reacquired for safety reasons. Therefore, it's possible for a race to occur if the journal is closed in the background while rbd-mirror is accessing it w/o holding the necessary locks.

One specific example is in 'ImageReplayer::shut_down' where 'librbd::Journal::stop_external_replay' is invoked without holding the owner lock.

http://teuthology.ovh.sepia.ceph.com/teuthology/jdillaman-2016-06-10_03:05:15-rbd-master---basic-openstack/21667/teuthology.log


Related issues 1 (0 open1 closed)

Copied to rbd - Backport #16425: jewel: rbd-mirror: potential race condition accessing local image journal ResolvedLoïc DacharyActions
Actions

Also available in: Atom PDF