Actions
Bug #10010
closedceph_osd.cc calls global_init_shutdown_stderr even when running with -f or -d flags
% Done:
0%
Source:
other
Tags:
Backport:
firefly
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
ceph-osd is difficult to debug in operation when running under systemd or docker, or any other system that expects to see error logs appear via STDOUT+STDERR, because ceph_osd.cc explicitly closes STDERR with a call to global_init_shutdown_stderr, without checking of the -f (foreground) or -d (debug) options are in use. With -d, this leads to all error messages being silently discarded with no logs at all, which is the precise opposite of what -d is supposed to do.
Code in either ceph_osd.cc or global_init.cc should check for foreground operation before closing STDERR.
Updated by Samuel Just over 9 years ago
- Assignee set to Sage Weil
- Priority changed from Normal to Urgent
Updated by Samuel Just over 9 years ago
- Assignee changed from Sage Weil to Dan Mick
Updated by Dan Mick over 9 years ago
- Status changed from New to Fix Under Review
Seems pretty simple; just check g_conf->daemonize, and don't close if not set.
Updated by Sage Weil over 9 years ago
- Status changed from Fix Under Review to Resolved
Actions