Actions
Bug #50934
closedChange of public type in snappy
Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
build
Target version:
-
% Done:
0%
Source:
Development
Tags:
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Description
Just a head-up, the snappy folks just silently made this between version 1.1.8 and 1.1.9 in snappy.h (not even mentioned in the NEWS nor Changelog)
< bool GetUncompressedLength(Source* source, uint32_t* result); --- > bool GetUncompressedLength(Source* source, uint32* result);
The fix:
--- ceph-16.2.4/src/compressor/snappy/SnappyCompressor.h.orig 2021-05-22 21:04:35.132581681 +0200
+++ ceph-16.2.4/src/compressor/snappy/SnappyCompressor.h 2021-05-22 21:04:54.563289389 +0200
@@ -97,7 +97,7 @@
if (qat_enabled)
return qat_accel.decompress(p, compressed_len, dst, compressor_message);
#endif
- snappy::uint32 res_len = 0;
+ snappy::uint32_t res_len = 0;
BufferlistSource source_1(p, compressed_len);
if (!snappy::GetUncompressedLength(&source_1, &res_len)) {
return -1;
Updated by Nathan Cutler over 2 years ago
- Tracker changed from Fix to Bug
- Status changed from New to Fix Under Review
- Regression set to No
- Severity set to 3 - minor
- Pull request ID set to 42507
Updated by Nathan Cutler over 2 years ago
- Pull request ID changed from 42507 to 42516
Updated by Kefu Chai over 2 years ago
- Status changed from Fix Under Review to Pending Backport
Updated by Backport Bot over 2 years ago
- Copied to Backport #51955: pacific: Change of public type in snappy added
Updated by Loïc Dachary over 2 years ago
- Status changed from Pending Backport to Resolved
While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".
Actions