Project

General

Profile

Cleanup #43171

Updated by Nathan Cutler over 4 years ago

A recent commit [1] disabled meant to disable "make check" for rhel8 by adding a conditional: 

 <pre> 
 %if 0%{?rhel} < 8 
 </pre> 

 This change has unintended consequences, because the conditional evalates to "true" in two cases: 

 * whenever the rhel macro is undefined (i.e. on non-RHEL distros) 
 * when the rhel macro is defined *and* set to a number less than 8 

 This change is potentially misleading and makes the spec file harder to understand. Also, there is a section of the spec file designated for distro-conditional make check dependencies, so it makes sense to move this code into that section. undefined. 

 [1] https://github.com/ceph/ceph/commit/e92cb7a0336406a2981e9241031497b1749b26aa

Back