Project

General

Profile

Actions

Cleanup #43171

closed

ceph.spec.in: RHEL distro conditional evaluates to true for non-RHEL distros

Added by Nathan Cutler over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

A recent commit [1] disabled "make check" for rhel8 by adding a conditional:

%if 0%{?rhel} < 8

This conditional evalates to "true" in two cases:

  • whenever the rhel macro is undefined (i.e. on non-RHEL distros)
  • when the rhel macro is defined and set to a number less than 8

This change is potentially misleading and makes the spec file harder to understand. Also, there is a section of the spec file designated for distro-conditional make check dependencies, so it makes sense to move this code into that section.

[1] https://github.com/ceph/ceph/commit/e92cb7a0336406a2981e9241031497b1749b26aa

Actions #1

Updated by Nathan Cutler over 4 years ago

  • Description updated (diff)
Actions #2

Updated by Nathan Cutler over 4 years ago

  • Tracker changed from Bug to Cleanup
Actions #3

Updated by Brad Hubbard over 4 years ago

  • Pull request ID set to 32080
Actions #4

Updated by Nathan Cutler over 4 years ago

  • Status changed from In Progress to Fix Under Review
Actions #5

Updated by Nathan Cutler over 4 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF