Tasks #889
closedlibrbd.cc : more int ->uint64_t
0%
Description
Hi ,
1.
commit : 4ee75a881ec637e2b0c5b74b16b1e44ac710707c
still exist some of params that need modify int ->uint64_t .
example : total_read ,total_write.
at read_iterate function, should modify
"int total_read = 0;"
to
"uint64_t total_read = 0;"
,or rbd export file size >2GB ,still fail.
i listed some of the functions at the below.
int read_iterate(ImageCtx *ictx, uint64_t off, size_t len,
int (*cb)(uint64_t, size_t, const char *, void *),
void *arg)
{
int r = ictx_check(ictx);
if (r < 0)
return r;
{
if (!len)
return 0;
int r = ictx_check(ictx);
if (r < 0)
return r;
int total_write = 0;
..............
int aio_read(ImageCtx *ictx, uint64_t off, size_t len,
char *buf,
AioCompletion *c)
{
..............
int total_read = 0;
...............
}
int write(ImageCtx *ictx, uint64_t off, size_t len, const char *buf)
{
if (!len)
return 0;
int r = ictx_check(ictx);
if (r < 0)
return r;
int total_write = 0;
..............................
}
2. to suggest, modify some of functions that "int" ->"int64_t"
example :
modify:
int read_iterate(ImageCtx *ictx, uint64_t off, size_t len,
int (*cb)(uint64_t, size_t, const char *, void *),
void *arg)
to
int64_t read_iterate(ImageCtx *ictx, uint64_t off, size_t len,
int (*cb)(uint64_t, size_t, const char *, void *),
void *arg)
read,write,aio_read,aio_write ,etc.