Fix #8205
closedFileStore: properly fill in XATTR_NO_SPILL_OUT tag
0%
Description
Right now, the only way the FileStore sets the XATTR_SPILL_OUT_NAME xattr to contain XATTR_NO_SPILL_OUT is when removing xattrs. We need to fill them in when creating objects, too. This is probably just a minor case adjustment in FileStore::_setattrs() to include one where we write set the xattr.
Updated by Greg Farnum about 10 years ago
- Status changed from New to In Progress
- Assignee set to Greg Farnum
wip-xattr-spillout exists but is untested.
Updated by Greg Farnum almost 10 years ago
- Status changed from In Progress to 7
Significantly revised the branch (it now removes the user_only stuff in the ObjectStore interface), and have scheduled a suite run against it.
It passed my trivial test (ran rados bench, checked file on disk, it now has the spillout xattr, where it did not with master).
Updated by Greg Farnum almost 10 years ago
- Status changed from 7 to In Progress
I ran this branch through testing and it wasn't passing; it appears to be some kind of issue with the spillout logic itself (that we didn't notice previously because it wasn't exercised), but maybe something else is going on. I'm discussing with Haomai on the mailing list.
Updated by Greg Farnum almost 10 years ago
- Status changed from In Progress to Pending Backport
This is in master now, but we'll need to backport to Firefly after it's been through some nightlies. (Unless we don't want to put it in Firefly, but I think people will be happier if we do.)
Updated by Sage Weil almost 10 years ago
- Status changed from Pending Backport to Resolved
in firefly branch now