Project

General

Profile

Fix #8205

FileStore: properly fill in XATTR_NO_SPILL_OUT tag

Added by Greg Farnum over 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
OSD
Target version:
-
Start date:
04/24/2014
Due date:
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

Right now, the only way the FileStore sets the XATTR_SPILL_OUT_NAME xattr to contain XATTR_NO_SPILL_OUT is when removing xattrs. We need to fill them in when creating objects, too. This is probably just a minor case adjustment in FileStore::_setattrs() to include one where we write set the xattr.

Associated revisions

Revision e3b995e1 (diff)
Added by Greg Farnum about 5 years ago

FileStore: set XATTR_NO_SPILL_OUT when creating new files.

Fixes: #8205
Backport: firefly

Signed-off-by: Greg Farnum <>

Revision b758fd5f (diff)
Added by Greg Farnum about 5 years ago

FileStore: set XATTR_NO_SPILL_OUT when creating new files.

Fixes: #8205
Backport: firefly

Signed-off-by: Greg Farnum <>
(cherry picked from commit e3b995e1567f3ccc6d00ae27ab2aa99ca157228a)

History

#1 Updated by Greg Farnum over 5 years ago

  • Status changed from New to In Progress
  • Assignee set to Greg Farnum

wip-xattr-spillout exists but is untested.

#2 Updated by Greg Farnum over 5 years ago

  • Status changed from In Progress to Testing

Significantly revised the branch (it now removes the user_only stuff in the ObjectStore interface), and have scheduled a suite run against it.

It passed my trivial test (ran rados bench, checked file on disk, it now has the spillout xattr, where it did not with master).

#3 Updated by Greg Farnum about 5 years ago

  • Status changed from Testing to In Progress

I ran this branch through testing and it wasn't passing; it appears to be some kind of issue with the spillout logic itself (that we didn't notice previously because it wasn't exercised), but maybe something else is going on. I'm discussing with Haomai on the mailing list.

#4 Updated by Greg Farnum about 5 years ago

  • Status changed from In Progress to Pending Backport

This is in master now, but we'll need to backport to Firefly after it's been through some nightlies. (Unless we don't want to put it in Firefly, but I think people will be happier if we do.)

#5 Updated by Sage Weil about 5 years ago

  • Status changed from Pending Backport to Resolved

in firefly branch now

Also available in: Atom PDF