Project

General

Profile

Actions
Copy link

Bug #761

closed

librbd: Include path to librados

Added by Wido den Hollander about 13 years ago. Updated about 13 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Yehuda Sadeh
Category:
librbd
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

In librbd.hpp and librbd.h we have:

librbd.h

#include "librados.h"

librbd.hpp

#include "buffer.h" 
#include "librados.hpp" 
#include "librbd.h"

This works when compiling the packages, since at the moment all the headers are in "src/include".

But when deployed on a system these headers are not.

It should then be:

#include "rados/librados.h"

and
#include "rados/buffer.h" 
#include "rados/librados.hpp" 
#include "librbd.h"

Changing this in the headers enables compiling external clients against librbd, but the building of the packages fails.

We could change the structure in the repo? Make some subdirectories in "src/include" to achieve what we want.

Actions
Copy link
 #1

Updated by Sage Weil about 13 years ago

  • Assignee set to Yehuda Sadeh
Actions
Copy link
 #2

Updated by Yehuda Sadeh about 13 years ago

  • Status changed from New to Resolved

commit:ee20a7921253eddf52f91e5e0be08543d8e59037 should fix it. Did some reshuffling, now the include files within the source tree are either under include/rados/ or under include/rbd/.

Actions
Copy link

Also available in: Atom PDF