Cleanup #7586
open
deprecate rados_pool_create
Added by Loïc Dachary about 10 years ago.
Updated over 4 years ago.
Description
rados_pool_create must support properties to enable the creation of erasure coded pools
rados_mon_command can be used instead. Adding arguments to rados_pool_create requires modifications to a number of prototypes as well as the MPoolOp service message.
sage & josh & sam recommend deprecating rados_pool_create
- Priority changed from Urgent to Normal
<loicd> davidzlap: are you blocked in any way because http://ceph.com/docs/master/rados/api/librados/#rados_pool_create cannot create erasure coded pools ? Or is http://ceph.com/docs/master/rados/api/librados/#rados_mon_command good enough ?
<davidzlap> loicd: not sure… what the difference is.
<davidzlap> oh..I was probably going to use rados_pool_create() or the C++ version
<loicd> with rados_mon_command you could create a list of arguments such as : osd pool create ecpool666 12 12 erasure erasure-code-k=2 erasure-code-m=1 erasure-code-ruleset-failure-domain=osd
<sjustwork> davidzlap: that would be a good workaround for the time being
<davidzlap> ok…I was going to work on something else but I'll do that if you don't have the other ready.
<loicd> why is rados_pool_create better than rados_mon_command to create a pool ?
<sjustwork> loicd: I didn't know about rados_mon_command
<sjustwork> might be fine for that to be the answer
<loicd> I think the difference is access control. rados_pool_create can be used by a user with MON_CAP_W and rados_mon_command presumably requires more privileges.
<sage_> fwiw it would be nice to deprecate rados_pool_create
<sage_> pool create is really a mgmt operation
<joshd1> ++
<joshd1> the existing interface doesn't allow specifying pgnum as well
<joshd1> if the string wrangling isn't too bad I'd recommend rados_mon_command(), I'm not sure there's any access control difference
<sjustwork> seems reasonable to me
- Tracker changed from Feature to Cleanup
- Subject changed from erasure-code: add support to rados_pool_create to erasure-code: deprecate rados_pool_create
- Description updated (diff)
- Subject changed from erasure-code: deprecate rados_pool_create to deprecate rados_pool_create
- Description updated (diff)
- Assignee deleted (
Loïc Dachary)
- Target version deleted (
0.78)
- Status changed from 12 to New
Also available in: Atom
PDF