Actions
Bug #6806
closedmon: audit cmd_getval() calls to make sure they handle failures correctly
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
During #6796 we noticed that most calls to cmd_getval() do not care for the function's return value, which indicates whether it was successful in parsing the value with the expected type. This can cause all sorts of problems in the monitors, specially considering that most of these values will end up uninitialized.
Not only can this be a problem on a mixed-version cluster if variable types are different (see #6796), but it can also be problematic if a malicious user intents on causing mayhem.
Actions