Project

General

Profile

Actions

Bug #65511

open

cephadm: anonymous_access: false is dropped from grafana spec after apply

Added by Adam King 14 days ago. Updated 14 days ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
squid, reef, quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

[ceph: root@vm-00 /]# cat grafana.yaml 
service_type: grafana
service_name: grafana
placement:
  count: 1
spec:
  anonymous_access: False
  initial_admin_password: password
  protocol: https
[ceph: root@vm-00 /]# 
[ceph: root@vm-00 /]# 
[ceph: root@vm-00 /]# ceph orch apply -i grafana.yaml 
Scheduled grafana update...
[ceph: root@vm-00 /]# 
[ceph: root@vm-00 /]# 
[ceph: root@vm-00 /]# ceph orch ls grafana --export               
service_type: grafana
service_name: grafana
placement:
  count: 1
spec:
  anonymous_access: true
  initial_admin_password: password
  protocol: https

This seems to be because it is a bool that defaults to true, which in hindsight was a bad idea. However, it has been merged and backported to the reef and quincy branches for over a year now, so it's hard to change the attribute. I think for this case we may need special handling when converting grafana specs from python objects to JSON serializable dicts.

Actions #1

Updated by Adam King 14 days ago

  • Subject changed from cephadm: anonymous_access: true is dropped from grafana spec after apply to cephadm: anonymous_access: false is dropped from grafana spec after apply
  • Description updated (diff)
Actions #2

Updated by Adam King 14 days ago

  • Description updated (diff)
Actions #3

Updated by Adam King 14 days ago

  • Pull request ID set to 56928
Actions

Also available in: Atom PDF