Project

General

Profile

Actions

Bug #63018

open

notifications: same queue is shared between tenants for persistent notifications

Added by Yuval Lifshitz 7 months ago. Updated 7 months ago.

Status:
New
Priority:
Normal
Target version:
-
% Done:

0%

Source:
Development
Tags:
notifications
Backport:
reef
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Actions #1

Updated by Yuval Lifshitz 7 months ago

to reproduce: https://gist.github.com/yuvalif/e4ab558dbed63fae18e28848be0bb49a

note that the right solution is to add the tenant name to the topic name when creating the name of the queue object.
however, doing that will create backward compatibility issues.
  • when creating a new persistent topic, that did not exist before, this is ok to just add the tenant
  • when handling the queues we just follow the names in the list of owned queues, so, there should not be any issue there
  • when doing reserve/commit we should first add the tenant to the topic arn, to get the queue name, if we get ENOENT, we should create a new queue with the correct name, and use it
  • when reading the stats in the admin command, we can probably first check for the name with the tenant, and then also look for the name without the tenat (and probably print a warning)
  • when calling get topic in the admin command, we should also check for the name without the tenant, and print a warning if found
  • we should add option to the "topic rm' command to delete the non-tenanted queue of tenanted topic
Actions #2

Updated by Casey Bodley 7 months ago

  • Assignee set to Yuval Lifshitz
Actions

Also available in: Atom PDF