Project

General

Profile

Actions

Bug #62384

open

notifications: optimize duplicate data stored in the notification wrapper

Added by Yuval Lifshitz 9 months ago. Updated 9 months ago.

Status:
New
Priority:
Normal
Target version:
-
% Done:

0%

Source:
Development
Tags:
notifications
Backport:
reef
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

currently the notification wrapper is holding data which is per notification as well as conf data from the topic:

struct event_entry_t {
  rgw_pubsub_s3_event event;            // notification specific
  std::string push_endpoint;            // topic conf
  std::string push_endpoint_args;       // topic conf
  std::string arn_topic;                // topic conf
  ceph::coarse_real_time creation_time; // notification specific
};

these are large identical strings that may be duplicated large number of times.

to fix this, we should add the topic conf as omap attributes of the queue object instead of duplicating them per entry (e.g. in the "add_persistent_topic()")
the code will have to be able to support both, ad we would probably have to encode empty strings into these parameters since they are in the middle of the struct.

Actions #1

Updated by Casey Bodley 9 months ago

  • Assignee set to Yuval Lifshitz
Actions

Also available in: Atom PDF