Project

General

Profile

Actions

Bug #5982

closed

injectargs seems to be broken for bools

Added by Samuel Just over 10 years ago. Updated over 10 years ago.

Status:
Rejected
Priority:
Immediate
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
dumpling,bobtail
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

ceph2/src [wip-5910] » ./ceph tell osd.\* injectargs '--osd_recover_clone_overlap=false'
  • DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH **
    Invalid command: saw 0 of injected_args(<string>) [<string>...], expected at least 1
    osd.0: Error EINVAL: invalid command
    osd.0: invalid command
    Invalid command: saw 0 of injected_args(<string>) [<string>...], expected at least 1
    osd.1: Error EINVAL: invalid command
    osd.1: invalid command
    Invalid command: saw 0 of injected_args(<string>) [<string>...], expected at least 1
    osd.2: Error EINVAL: invalid command
    osd.2: invalid command
    ceph2/src [wip-5910] » ./ceph tell osd.\
    injectargs '--osd_recover_clone_overlap 0'
  • DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
    osd.0: failed to parse arguments: 0
    osd_recover_clone_overlap = 'true'
    osd.1: failed to parse arguments: 0
    osd_recover_clone_overlap = 'true'
    osd.2: failed to parse arguments: 0
    osd_recover_clone_overlap = 'true'
ceph2/src [wip-5910] » ./ceph tell osd.\* injectargs '--osd_map_dedup 0'
  • DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH **
    osd.0: failed to parse arguments: 0
    osd_map_dedup = 'true'
    osd.1: failed to parse arguments: 0
    osd_map_dedup = 'true'
    osd.2: failed to parse arguments: 0
    osd_map_dedup = 'true'
    ceph2/src [wip-5910] » ./ceph tell osd.\
    injectargs '--osd_map_dedup false'
  • DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
    osd.0: failed to parse arguments: false
    osd_map_dedup = 'true'
    osd.1: failed to parse arguments: false
    osd_map_dedup = 'true'
    osd.2: failed to parse arguments: false
    osd_map_dedup = 'true'
Actions #1

Updated by Samuel Just over 10 years ago

also for admin socket

Actions #2

Updated by Sage Weil over 10 years ago

you need a -- to make the cli stop parsing the option. or a space in there.

ceph tell osd.0 injectargs -- --some-option
ceph tell osd.0 injectargs '--some-option --another-option'

Actions #3

Updated by Stefan Priebe over 10 years ago

at least to me this doesn't change anything:
ceph osd tell \* injectargs -- "--osd_recover_clone_overlap false"
ok

2013-08-15 21:51:11.962858 osd.12 [INF] failed to parse arguments: false
2013-08-15 21:51:11.962860 osd.12 [INF] osd_recover_clone_overlap = 'true'

Actions #4

Updated by Sage Weil over 10 years ago

Stefan Priebe wrote:

at least to me this doesn't change anything:
ceph osd tell \* injectargs -- "--osd_recover_clone_overlap false"
ok

2013-08-15 21:51:11.962858 osd.12 [INF] failed to parse arguments: false
2013-08-15 21:51:11.962860 osd.12 [INF] osd_recover_clone_overlap = 'true'

ceph osd tell \* injectargs -- --osd_recover_clone_overlap=false

or

ceph osd tell \* injectargs -- --no-osd-recover-clone-overlap

Actions #5

Updated by Sage Weil over 10 years ago

  • Status changed from New to Rejected
Actions

Also available in: Atom PDF