Feature #58072
closed
I think at this point we should consider making it possible to set arbitrary settings on a fs during creation. i.e. anything `ceph fs set` can do.
Patrick Donnelly wrote:
I think at this point we should consider making it possible to set arbitrary settings on a fs during creation. i.e. anything `ceph fs set` can do.
Arbitrary setting? I'm not sure if i understand this correctly but https://github.com/ceph/ceph/pull/48720 added option `refuse_client_session` to `ceph fs set`. Did I misinterpret this or do I need to do something else?
Dhairya Parmar wrote:
Patrick Donnelly wrote:
I think at this point we should consider making it possible to set arbitrary settings on a fs during creation. i.e. anything `ceph fs set` can do.
Arbitrary setting? I'm not sure if i understand this correctly but https://github.com/ceph/ceph/pull/48720 added option `refuse_client_session` to `ceph fs set`. Did I misinterpret this or do I need to do something else?
Or did you mean to allow `fs new` to support all options of `fs set`?
Patrick Donnelly wrote:
I think at this point we should consider making it possible to set arbitrary settings on a fs during creation. i.e. anything `ceph fs set` can do.
In that case perhaps it's better to add an option that allows setting key-value pairs to ceph fs new
command. This would look like following -
ceph fs new --set-flag max_mds 6
ceph fs new --set-flag refuse_client_session true
ceph fs new --set-flag session timeout 400
Rishabh Dave wrote:
Patrick Donnelly wrote:
I think at this point we should consider making it possible to set arbitrary settings on a fs during creation. i.e. anything `ceph fs set` can do.
In that case perhaps it's better to add an option that allows setting key-value pairs to ceph fs new
command. This would look like following -
[...]
Yes, this is exactly what I mean. But I would use `--set <key> <value>` instead. A "flag" is conventionally a binary option.
Patrick Donnelly wrote:
Rishabh Dave wrote:
Patrick Donnelly wrote:
I think at this point we should consider making it possible to set arbitrary settings on a fs during creation. i.e. anything `ceph fs set` can do.
In that case perhaps it's better to add an option that allows setting key-value pairs to ceph fs new
command. This would look like following -
[...]
Yes, this is exactly what I mean. But I would use `--set <key> <value>` instead. A "flag" is conventionally a binary option.
Alright, thanks
- Subject changed from add --refuse_client_session flag to 'ceph fs new' command to enable 'ceph fs new' use 'ceph fs set' options
- Status changed from New to In Progress
- Pull request ID set to 51993
- Status changed from In Progress to Fix Under Review
- Status changed from Fix Under Review to Resolved
Also available in: Atom
PDF