Project

General

Profile

Feature #58072

enable 'ceph fs new' use 'ceph fs set' options

Added by Dhairya Parmar over 1 year ago. Updated 8 months ago.

Status:
Fix Under Review
Priority:
Normal
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Component(FS):
Client, MDS
Labels (FS):
task(easy)
Pull request ID:

Description

As discussed in PR [1], this flag would come handy in situations like 'ceph fs new --recover'. Need to push this enhancement after [1] is merged.

[1] https://github.com/ceph/ceph/pull/48720

History

#1 Updated by Patrick Donnelly over 1 year ago

I think at this point we should consider making it possible to set arbitrary settings on a fs during creation. i.e. anything `ceph fs set` can do.

#2 Updated by Dhairya Parmar 11 months ago

Patrick Donnelly wrote:

I think at this point we should consider making it possible to set arbitrary settings on a fs during creation. i.e. anything `ceph fs set` can do.

Arbitrary setting? I'm not sure if i understand this correctly but https://github.com/ceph/ceph/pull/48720 added option `refuse_client_session` to `ceph fs set`. Did I misinterpret this or do I need to do something else?

#3 Updated by Dhairya Parmar 11 months ago

Dhairya Parmar wrote:

Patrick Donnelly wrote:

I think at this point we should consider making it possible to set arbitrary settings on a fs during creation. i.e. anything `ceph fs set` can do.

Arbitrary setting? I'm not sure if i understand this correctly but https://github.com/ceph/ceph/pull/48720 added option `refuse_client_session` to `ceph fs set`. Did I misinterpret this or do I need to do something else?

Or did you mean to allow `fs new` to support all options of `fs set`?

#4 Updated by Rishabh Dave 11 months ago

Patrick Donnelly wrote:

I think at this point we should consider making it possible to set arbitrary settings on a fs during creation. i.e. anything `ceph fs set` can do.

In that case perhaps it's better to add an option that allows setting key-value pairs to ceph fs new command. This would look like following -

ceph fs new --set-flag max_mds 6
ceph fs new --set-flag refuse_client_session true
ceph fs new --set-flag session timeout 400

#5 Updated by Patrick Donnelly 11 months ago

Rishabh Dave wrote:

Patrick Donnelly wrote:

I think at this point we should consider making it possible to set arbitrary settings on a fs during creation. i.e. anything `ceph fs set` can do.

In that case perhaps it's better to add an option that allows setting key-value pairs to ceph fs new command. This would look like following -
[...]

Yes, this is exactly what I mean. But I would use `--set <key> <value>` instead. A "flag" is conventionally a binary option.

#6 Updated by Dhairya Parmar 11 months ago

Patrick Donnelly wrote:

Rishabh Dave wrote:

Patrick Donnelly wrote:

I think at this point we should consider making it possible to set arbitrary settings on a fs during creation. i.e. anything `ceph fs set` can do.

In that case perhaps it's better to add an option that allows setting key-value pairs to ceph fs new command. This would look like following -
[...]

Yes, this is exactly what I mean. But I would use `--set <key> <value>` instead. A "flag" is conventionally a binary option.

Alright, thanks

#7 Updated by Dhairya Parmar 8 months ago

  • Subject changed from add --refuse_client_session flag to 'ceph fs new' command to enable 'ceph fs new' use 'ceph fs set' options
  • Status changed from New to In Progress
  • Pull request ID set to 51993

#8 Updated by Dhairya Parmar 8 months ago

  • Status changed from In Progress to Fix Under Review

Also available in: Atom PDF