Project

General

Profile

Actions

Documentation #57858

closed

v17.2.4 release does not contain latest cherry-picks

Added by Laura Flores over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Immediate
Category:
-
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Earlier today, I went to check one of the Telemetry commands in the Long Running Cluster, and the command caused a crash in the mgr.
The crash was one that we had already seen during our testing of the Quincy RC, and we have already pushed a commit to fix it.

After further investigation, I found that this commit, along with 4 other commits, were not included in the v17.2.4 release when they should have been.
These commits include:
mgr/telemetry: handle daemons with complex ids
ceph-volume: fix regression in activate
mgr/rook: fix error when trying to get the list of nfs services
Revert "osd/PeeringState: proc_lease_ack break once found from OSD"
Revert "osd/PeeringState: fix missed `recheck_readable` from laggy"

Adam King also verified this by checking a 17.2.4 container, which proved to not contain the ceph-volume patch.

It was after Quincy RC was initially declared that we upgraded the upstream clusters (Gibba and LRC) and found a handful of regressions. We fixed these
regressions with the above patches and added them to the Quincy RC, which we verified again on our upstream clusters. Unfortunately, due to a flaw in the release process, these last-minute patches were not included in v17.2.4. Currently, v17.2.4 is based on the older Quincy RC when it should be based on the latest version.

Here is a link to the latest Quincy RC branch, which should have been released as v17.2.4:
https://github.com/ceph/ceph/commits/quincy-release

Here is a link to v17.2.4, which does not contain 5 commits:
https://github.com/ceph/ceph/commits/v17.2.4

Here is a link to the diff between v17.2.4 and quincy-release. The 5 commits shown should have been included in v17.2.4:
https://github.com/ceph/ceph/compare/v17.2.4...quincy-release

One missing piece of the puzzle is that this ceph-jenkins PR for v17.2.4 was never merged to Quincy, which means the v17.2.4 tag is not present in the Quincy branch: https://github.com/ceph/ceph/pull/48290

Actions

Also available in: Atom PDF