Ceph » CephFS

This should be fixed by https://github.com/ceph/ceph/pull/45614, in https://github.com/ceph/ceph/pull/45614/files#diff-27ee28966b05e5763e76677ae87f8626985eae114814c25bdc45eef15c3455f0R596-R601.

Xiubo Li wrote:

This should be fixed by https://github.com/ceph/ceph/pull/45614, in https://github.com/ceph/ceph/pull/45614/files#diff-27ee28966b05e5763e76677ae87f8626985eae114814c25bdc45eef15c3455f0R596-R601.

Right. Let's get the changes backported.

Venky Shankar wrote:

Xiubo Li wrote:

This should be fixed by https://github.com/ceph/ceph/pull/45614, in https://github.com/ceph/ceph/pull/45614/files#diff-27ee28966b05e5763e76677ae87f8626985eae114814c25bdc45eef15c3455f0R596-R601.

Right. Let's get the changes backported.

Yeah sure, will do it this week.

I found one case could cause this, such as in the xfstests-dev's open_by_handle.c, which will use the name_to_handle_at() to store the struct fid, which will contains the ino#, but the name_to_handle_at() won't open the file.

118 struct fid {
119         union {
120                 struct {
121                         u32 ino;                                                                                                                   
122                         u32 gen;
123                         u32 parent_ino;                     
124                         u32 parent_gen;                     
125                 } i32;
126                 struct {
127                         u32 block;
128                         u16 partref;
129                         u16 parent_partref;
130                         u32 generation;                     
131                         u32 parent_block;
132                         u32 parent_generation;              
133                 } udf;
134                 __u32 raw[0];
135         };
136 };

Then the test case could use the above struct fid to open the file later by using open_by_handle_at(). So when opening the file later the file could be already deleted and the ino# already reused.