Project

General

Profile

Actions
Copy link

Bug #54452

open

Inverted check in RGWRados::check_disk_state()

Added by Daniel Gryniewicz about 2 years ago. Updated over 1 year ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
Daniel Gryniewicz
Target version:
-
% Done:

0%

Source:
Tags:
backport_processed
Backport:
quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
45225
Crash signature (v1):
Crash signature (v2):

Description

This code is inverted:

const bool head_pool_found =
    get_obj_head_ioctx(dpp, bucket_info, obj, &head_obj_ctx);
  if (head_pool_found) {

This is because get_obj_head_ioctx() returns the standard int, where 0 is success. Casting to bool inverts this.

Related issues 1 (1 open — 0 closed)

Copied to rgw - Backport #54608: quincy: Inverted check in RGWRados::check_disk_state()NewActions
Actions
Copy link
 #1

Updated by Daniel Gryniewicz about 2 years ago

  • Pull request ID set to 45225
Actions
Copy link
 #2

Updated by Daniel Gryniewicz about 2 years ago

  • Status changed from New to Fix Under Review
Actions
Copy link
 #3

Updated by Daniel Gryniewicz about 2 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #4

Updated by Backport Bot about 2 years ago

  • Copied to Backport #54608: quincy: Inverted check in RGWRados::check_disk_state() added
Actions
Copy link
 #5

Updated by Backport Bot over 1 year ago

  • Tags set to backport_processed
Actions
Copy link

Also available in: Atom PDF