Project

General

Profile

Actions

Cleanup #54252

closed

Nose is no longer maintained and is now actively breaking test runs

Added by Steve Kowalik about 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Tags:
Backport:
quincy,pacific
Reviewed:
Affected Versions:
Pull request ID:

Description

Nose has been abandoned by upstream for quite some time1, and has already
caused at least one bug with reproducable failures2.

We should stop making use of it and switch to either plain unittest or pytest.

% git grep -c 'from nose'
doc/radosgw/session-tags.rst:1
src/test/pybind/test_ceph_argparse.py:1
src/test/pybind/test_cephfs.py:1
src/test/pybind/test_rados.py:3
src/test/pybind/test_rbd.py:2
src/test/pybind/test_rgwfs.py:1
src/test/rgw/bucket_notification/test_bn.py:3
src/test/rgw/rgw_multi/tests.py:3
src/test/rgw/rgw_multi/tests_az.py:2
src/test/rgw/rgw_multi/tests_es.py:1
src/test/rgw/rgw_multi/tests_ps.py:2
src/test/rgw/rgw_multi/zone_cloud.py:1
src/test/rgw/rgw_multi/zone_es.py:1
src/test/rgw/rgw_multi/zone_rados.py:1

% git grep -ce '-m nose'
qa/workunits/fs/test_python.sh:1
qa/workunits/rados/test_python.sh:1
qa/workunits/rbd/test_librbd_python.sh:2
qa/workunits/rgw/run-s3tests.sh:1
src/test/pybind/CMakeLists.txt:2
src/test/rgw/bucket_notification/README.rst:2
src/test/run-rbd-tests:1

1: https://github.com/nose-devs/nose/issues/1099#issuecomment-562394879
2: https://tracker.ceph.com/issues/53478


Related issues 2 (0 open2 closed)

Copied to Ceph - Backport #55615: quincy: Nose is no longer maintained and is now actively breaking test runsResolvedTim SerongActions
Copied to Ceph - Backport #55616: pacific: Nose is no longer maintained and is now actively breaking test runsResolvedTim SerongActions
Actions #1

Updated by Steve Kowalik about 2 years ago

From what I can see, most of the files under src/test/pybind aren't even run as part of the test suite, for example test_cephfs.py

Actions #2

Updated by Tim Serong about 2 years ago

  • Pull request ID set to 45064
Actions #3

Updated by Tim Serong about 2 years ago

  • Status changed from New to Fix Under Review
  • Backport set to quincy,pacific
Actions #4

Updated by Casey Bodley almost 2 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #5

Updated by Backport Bot almost 2 years ago

  • Copied to Backport #55615: quincy: Nose is no longer maintained and is now actively breaking test runs added
Actions #6

Updated by Backport Bot almost 2 years ago

  • Copied to Backport #55616: pacific: Nose is no longer maintained and is now actively breaking test runs added
Actions #7

Updated by Tim Serong almost 2 years ago

  • Status changed from Pending Backport to Resolved

All backports merged, marking resolved

Actions

Also available in: Atom PDF