Cleanup #54032: unused functions/variables - Ceph - Ceph

Actions

Copy link

Cleanup #54032

closed

unused functions/variables

Added by Matan Breizman about 2 years ago. Updated about 2 years ago.

Status:

Resolved

Priority:

Low

Assignee:

Category:

Target version:

% Done:

Tags:

low-hanging-fruit, good-first-issue

Backport:

Reviewed:

Affected Versions:

Pull request ID:

45221

Description

g16d1300b/rpm/el8/BUILD/ceph-17.0.0-10431-g16d1300b/src/test/librados/aio_cxx.cc:2247:18: warning: unused variable ‘c’ [-Wunused-variable]
 2247 |   AioCompletion *c = (AioCompletion*)cb;
      |                  ^

g16d1300b/rpm/el8/BUILD/ceph-17.0.0-10431-g16d1300b/src/common/numa.cc:10:
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-10431-g16d1300b/rpm/el8/BUILD/ceph-17.0.0-10431-g16d1300b/src/common/numa.cc: In function ‘std::string get_task_comm(pid_t)’:
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-10431-g16d1300b/rpm/el8/BUILD/ceph-17.0.0-10431-g16d1300b/src/common/numa.cc:176:12: warning: comparison of integer expressions of different signedness: ‘ssize_t’ {aka ‘long int’} and ‘long unsigned int’ [-Wsign-compare]
  176 |   assert(n <= sizeof(name));
      |          ~~^~~~~~~~~~~~~~~
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-10431-g16d1300b/rpm/el8/BUILD/ceph-17.0.0-10431-g16d1300b/src/common/numa.cc: At global scope:
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-10431-g16d1300b/rpm/el8/BUILD/ceph-17.0.0-10431-g16d1300b/src/common/numa.cc:159:20: warning: ‘std::string get_task_comm(pid_t)’ defined but not used [-Wunused-function]
  159 | static std::string get_task_comm(pid_t tid)
      |                    ^~~~~~~~~~~~~

build log: https://jenkins.ceph.com/job/ceph-dev-new-build/60116/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos8,DIST=centos8,MACHINE_SIZE=gigantic/consoleFull

Actions

Copy link

Updated by Matan Breizman about 2 years ago

Subject changed from used functions/variables to unused functions/variables

Actions

Copy link

Updated by Deepika Upadhyay about 2 years ago

Translation missing: en.field_tag_list set to low-hanging-fruit, good-first-issue

Actions

Copy link

Updated by Matan Breizman about 2 years ago

Matan Breizman wrote:

[...]

[...]

build log: https://jenkins.ceph.com/job/ceph-dev-new-build/60116/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos8,DIST=centos8,MACHINE_SIZE=gigantic/consoleFull

Second warning is fixed here: https://github.com/ceph/ceph/pull/44794

Actions

Copy link

Updated by Anshul Singh about 2 years ago

Matan Breizman wrote:

Matan Breizman wrote:

[...]

[...]

build log: https://jenkins.ceph.com/job/ceph-dev-new-build/60116/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos8,DIST=centos8,MACHINE_SIZE=gigantic/consoleFull

Second warning is fixed here: https://github.com/ceph/ceph/pull/44794

Please assign this issue to me. Github ID : https://github.com/levihackerman-102

Actions

Copy link

Updated by Anshul Singh about 2 years ago

Matan Breizman wrote:

[...]

[...]

build log: https://jenkins.ceph.com/job/ceph-dev-new-build/60116/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos8,DIST=centos8,MACHINE_SIZE=gigantic/consoleFull

Second warning is fixed here: https://github.com/ceph/ceph/pull/44794