Project

General

Profile

Actions
Copy link

Bug #53594

closed

mgr/cephadm/upgrade.py: normalize_image_digest has a hard coded constant to docker.io

Added by Sebastian Wagner over 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Sebastian Wagner
Category:
cephadm
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
44306
Crash signature (v1):
Crash signature (v2):

Description

https://github.com/ceph/ceph/blob/84f88eaec44103edd377817e264d5d376df8c554/src/pybind/mgr/cephadm/upgrade.py#L34

I mean it's clearly wrong as this depends on the search-regiestries setting of the hosts and is not a constant.

Can we drop this "normalizing" step altogether?

Still, we have to avoid creating a regression to https://github.com/ceph/ceph/pull/40577

Actions
Copy link

Also available in: Atom PDF