Project

General

Profile

Bug #53594

mgr/cephadm/upgrade.py: normalize_image_digest has a hard coded constant to docker.io

Added by Sebastian Wagner 5 months ago. Updated 4 months ago.

Status:
Pending Backport
Priority:
Normal
Category:
cephadm
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

https://github.com/ceph/ceph/blob/84f88eaec44103edd377817e264d5d376df8c554/src/pybind/mgr/cephadm/upgrade.py#L34

I mean it's clearly wrong as this depends on the search-regiestries setting of the hosts and is not a constant.

Can we drop this "normalizing" step altogether?

Still, we have to avoid creating a regression to https://github.com/ceph/ceph/pull/40577

History

#1 Updated by Adam King 5 months ago

This is also an issue in the binary https://github.com/ceph/ceph/blob/master/src/cephadm/cephadm#L4011.

That one actually causes issues when using a local repo and having use_repo_digest on. Since localhost:port/whatever has no "." in it it isn't considered a full name so when ever cephadm tries to pull the container digests it returns something like docker.io/localhost:port/whatever/SHA which it can't pull.

#2 Updated by Sebastian Wagner 5 months ago

  • Status changed from New to Fix Under Review
  • Assignee set to Sebastian Wagner
  • Pull request ID set to 44306

#4 Updated by Sebastian Wagner 4 months ago

  • Status changed from Fix Under Review to Pending Backport

Also available in: Atom PDF