Actions
Bug #53594
closedmgr/cephadm/upgrade.py: normalize_image_digest has a hard coded constant to docker.io
% Done:
0%
Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Description
I mean it's clearly wrong as this depends on the search-regiestries setting of the hosts and is not a constant.
Can we drop this "normalizing" step altogether?
Still, we have to avoid creating a regression to https://github.com/ceph/ceph/pull/40577
Updated by Adam King over 2 years ago
This is also an issue in the binary https://github.com/ceph/ceph/blob/master/src/cephadm/cephadm#L4011.
That one actually causes issues when using a local repo and having use_repo_digest on. Since localhost:port/whatever has no "." in it it isn't considered a full name so when ever cephadm tries to pull the container digests it returns something like docker.io/localhost:port/whatever/SHA which it can't pull.
Updated by Sebastian Wagner over 2 years ago
- Status changed from New to Fix Under Review
- Assignee set to Sebastian Wagner
- Pull request ID set to 44306
Updated by Sebastian Wagner over 2 years ago
Updated by Sebastian Wagner over 2 years ago
- Status changed from Fix Under Review to Pending Backport
Updated by Redouane Kachach Elhichou almost 2 years ago
- Status changed from Pending Backport to Resolved
Actions