Actions
Bug #53177
closedlogging in rgw_main.cc has wrong dout_prefix "rgw dbstore: "
% Done:
0%
Source:
Tags:
dbstore
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Description
log output during startup (with default rados configuration):
2021-11-05T14:20:52.286-0400 7ff71ad705c0 0 framework: beast 2021-11-05T14:20:52.286-0400 7ff71ad705c0 0 framework conf key: port, val: 8000 2021-11-05T14:20:52.286-0400 7ff71ad705c0 1 rgw dbstore: radosgw_Main not setting numa affinity 2021-11-05T14:20:52.290-0400 7ff70effd640 20 reqs_thread_entry: start 2021-11-05T14:20:52.290-0400 7ff71ad705c0 1 rgw dbstore: rgw_d3n: rgw_d3n_l1_local_datacache_enabled=0 2021-11-05T14:20:52.290-0400 7ff71ad705c0 1 rgw dbstore: D3N datacache enabled: 0
this happens because rgw_main.cc is (indirectly) including store/dbstore/common/dbstore_log.h, which sets the global dout prefix:
#define dout_prefix *_dout << "rgw dbstore: "
i think dbstore_log.h should only be included by dbstore source files
p.s. using namespace std; should never be used in header files
Actions