Project

General

Profile

Bug #53129

BlueFS truncate() and poweroff can create corrupted files

Added by Adam Kupczyk 11 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
pacific, octopus, nautilus
Regression:
Yes
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

It is possible to create condition in which a BlueFS contains file that is corrupted.
It can happen when BlueFS replay log is on device A and we just wrote to device B and truncated file.

Scenario:
1) write to file h1 on SLOW device
2) flush h1 (initiate data transfer, but no fdatasync yet)
3) truncate h1
4) write to file h2 on DB
5) fsync h2 (forces replay log to be written, after fdatasync to DB)
6) poweroff

In result we have file h1 that is properly declared in replay log, but with uninitialized content.
This happens even with
https://tracker.ceph.com/issues/50965
applied.

I think it is regression introduced by above fix.


Related issues

Copied to bluestore - Backport #53390: nautilus: BlueFS truncate() and poweroff can create corrupted files Rejected
Copied to bluestore - Backport #53391: pacific: BlueFS truncate() and poweroff can create corrupted files Resolved
Copied to bluestore - Backport #53392: octopus: BlueFS truncate() and poweroff can create corrupted files Resolved

History

#1 Updated by Adam Kupczyk 11 months ago

  • Description updated (diff)

#2 Updated by Neha Ojha 10 months ago

  • Status changed from New to Pending Backport

#3 Updated by Backport Bot 10 months ago

  • Copied to Backport #53390: nautilus: BlueFS truncate() and poweroff can create corrupted files added

#4 Updated by Backport Bot 10 months ago

  • Copied to Backport #53391: pacific: BlueFS truncate() and poweroff can create corrupted files added

#5 Updated by Backport Bot 10 months ago

  • Copied to Backport #53392: octopus: BlueFS truncate() and poweroff can create corrupted files added

#6 Updated by Adam Kupczyk 8 months ago

  • Pull request ID set to 43774

#7 Updated by Igor Fedotov 4 months ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF