Project

General

Profile

Bug #50965

In poweroff conditions BlueFS can create corrupted files

Added by Adam Kupczyk 5 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
pacific, octopus, nautilus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

It is possible to create condition in which a BlueFS contains file that is corrupted.
It can happen when BlueFS replay log is on device A and we just wrote to device B.

Scenario:
1) write to file h1 on SLOW device
2) flush h1 (and trigger h1 mark to be added to bluefs replay log, but no fdatasync yet)
3) write to file h2 on DB
4) fsync h2 (forces replay log to be written, after fdatasync to DB)
5) poweroff

In result we have file h1 that is properly declared in replay log, but with uninitialized content.


Related issues

Copied to bluestore - Backport #51128: octopus: In poweroff conditions BlueFS can create corrupted files Resolved
Copied to bluestore - Backport #51129: nautilus: In poweroff conditions BlueFS can create corrupted files Resolved
Copied to bluestore - Backport #51130: pacific: In poweroff conditions BlueFS can create corrupted files Resolved

History

#1 Updated by Adam Kupczyk 5 months ago

  • Pull request ID set to 41501

#2 Updated by Kefu Chai 5 months ago

  • Status changed from New to Resolved

#3 Updated by Dan van der Ster 5 months ago

Why doesn't this need to be backported? The commit applies cleanly to pacific, at least.

#4 Updated by Igor Fedotov 5 months ago

  • Status changed from Resolved to Pending Backport
  • Backport set to pacific, octopus, nautilus

#5 Updated by Backport Bot 5 months ago

  • Copied to Backport #51128: octopus: In poweroff conditions BlueFS can create corrupted files added

#6 Updated by Backport Bot 5 months ago

  • Copied to Backport #51129: nautilus: In poweroff conditions BlueFS can create corrupted files added

#7 Updated by Backport Bot 5 months ago

  • Copied to Backport #51130: pacific: In poweroff conditions BlueFS can create corrupted files added

#8 Updated by Loïc Dachary about 1 month ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Also available in: Atom PDF