Feature #53040: notifications: allow empty configuration to delete all notifications on a bucket - rgw - Ceph

Actions

Feature #53040

open

Status:

Pending Backport

Priority:

Normal

Assignee:

Target version:

% Done:

Source:

Support

Tags:

notifications backport_processed

Backport:

pacific

Reviewed:

Affected Versions:

Pull request ID:

Description

Related issues 1 (0 open — 1 closed)

Actions

Actions

items:

refactor the code that delete all notifications of the bucket into a separate function: https://github.com/ceph/ceph/blob/master/src/rgw/rgw_rest_pubsub.cc#L672
change the XML decode function invoked from here: https://github.com/ceph/ceph/blob/master/src/rgw/rgw_rest_pubsub.cc#L459
to not fail on empty configuration:
```
<NotificationConfiguration>
</NotificationConfiguration>
```
instead you should just keep the list of configurations inside "rgw_pubsub_s3_notifications" empty
that it is an "empty put"
here: https://github.com/ceph/ceph/blob/master/src/rgw/rgw_rest_pubsub.cc#L513
if we see an empty list, we should delete all notifications (the functions we refactored in the 1st step)
please make sure we add tests to teuthology