Fix #52916
open
mds,client: formally remove inline data support
Added by Jeff Layton over 2 years ago.
Updated almost 2 years ago.
Component(FS):
Client, MDS
Description
This feature was added and only half implemented several years ago, and we made a decision to start deprecating it in Octopus. Now that we're looking to ship Quincy, we should remove the feature altogether.
To do that though, we need the MDS to uninline file data on legacy filesystems that had it enabled at some point. Patrick suggested that the MDS scrubber should do this.
Related issues
2 (2 open — 0 closed)
- Related to Bug #52921: kclient: the read path is buggy when reading the inline data added
Patrick mentioned that we should probably have the scrubber just uninline any inodes that it detects that are inlined. It should be a pretty straightforward case of:
- find any inodes where inline_version != CEPH_INLINE_NONE
- xlock the inode (for File only? Or do we need other caps?)
- slurp out any inline_data in the inode, and write it to the appropriate object on the OSD
- set the inline_version to CEPH_INLINE_NONE
- unlock the inode
It's probably a bit more complex than that, but that should be basically what we need.
- Tracker changed from Bug to Fix
- Subject changed from formally remove inline data support to mds,client: formally remove inline data support
- Status changed from New to In Progress
- Assignee set to Milind Changire
- Target version set to v17.0.0
- Source set to Development
- Component(FS) Client, MDS added
- Labels (FS) scrub added
- Target version deleted (
v17.0.0)
- Related to Bug #64707: suites/fsstress.sh hangs on one client - test times out added
Also available in: Atom
PDF