Project

General

Profile

Actions
Copy link

Bug #52353

closed

cmake: handle empty CMAKE_THREAD_LIBS_INIT

Added by Ken Dreyer over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Ken Dreyer
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
42870
Crash signature (v1):
Crash signature (v2):

Description

CMAKE_THREAD_LIBS_INIT can be empty. On CentOS Stream 9, this leads to an error:

CMake Error at cmake/modules/Buildpmem.cmake:47 (set_target_properties):
  set_target_properties called with incorrect number of arguments.

My solution is to quote the variable so that cmake treats this as an empty string. With this change, cmake 3.20.2 succeeds on CentOS 9.

Related issues 1 (0 open — 1 closed)

Copied to Ceph - Backport #52610: pacific: cmake: handle empty CMAKE_THREAD_LIBS_INITResolvedKen DreyerActions
Actions
Copy link
 #1

Updated by Ken Dreyer over 2 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Ken Dreyer over 2 years ago

  • Pull request ID set to 42870
Actions
Copy link
 #3

Updated by Ken Dreyer over 2 years ago

  • Status changed from New to In Progress
  • Assignee set to Ken Dreyer
Actions
Copy link
 #4

Updated by Ken Dreyer over 2 years ago

  • Status changed from In Progress to Fix Under Review
Actions
Copy link
 #5

Updated by Ken Dreyer over 2 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #6

Updated by Backport Bot over 2 years ago

  • Copied to Backport #52610: pacific: cmake: handle empty CMAKE_THREAD_LIBS_INIT added
Actions
Copy link
 #7

Updated by Loïc Dachary over 2 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link

Also available in: Atom PDF