Actions
Bug #51369
closedvstart_runner: use FileNotFoundError instead of OSError
% Done:
100%
Source:
Tags:
backport_processed
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Description
Found a py3 compatibility-related TODO in vstart_runner.py
's clear_old_log()
-
from os import stat try: stat(logpath) # would need an update when making this py3 compatible. Use FileNotFound # instead. except OSError: return else: os.remove(logpath) with open(logpath, 'w') as logfile: logfile.write('') init_log() log.debug('logging in a fresh file now...')
Updated by Rishabh Dave almost 3 years ago
I suppose it's best to backport this fix to avoid re-discovery of this bug?
Updated by Rishabh Dave almost 3 years ago
- Status changed from In Progress to Fix Under Review
- Pull request ID set to 42029
Updated by Patrick Donnelly almost 3 years ago
- Status changed from Fix Under Review to Pending Backport
- Assignee set to Rishabh Dave
- Target version set to v17.0.0
- Source set to Development
- Backport set to pacific
Updated by Patrick Donnelly almost 3 years ago
- Tracker changed from Bug to Cleanup
Updated by Backport Bot almost 3 years ago
- Copied to Backport #51653: pacific: vstart_runner: use FileNotFoundError instead of OSError added
Updated by Konstantin Shalygin 3 months ago
- Tracker changed from Cleanup to Bug
- Status changed from Pending Backport to Resolved
- % Done changed from 0 to 100
- Regression set to No
- Severity set to 3 - minor
Actions