Project

General

Profile

Actions

Bug #51247

closed

notifications: add new type DeleteMarkerDeleted of event

Added by Yuval Lifshitz almost 3 years ago. Updated 8 months ago.

Status:
Won't Fix
Priority:
Low
Target version:
-
% Done:

0%

Source:
Q/A
Tags:
notifications
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

on versioned bucket, deleting the deleteMarkder has "eventTime":"0.000000" in event record

Actions #1

Updated by Yuval Lifshitz almost 3 years ago

  • Backport set to pacific
Actions #2

Updated by Yuval Lifshitz almost 3 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 41909
Actions #3

Updated by Yuval Lifshitz almost 3 years ago

  • Subject changed from notifications: zero time when deleting a delete marker to notifications: add new type DeleteMarkerDeleted of event
  • Status changed from Fix Under Review to In Progress
  • Pull request ID deleted (41909)
Actions #4

Updated by Yuval Lifshitz almost 3 years ago

  • Status changed from In Progress to New
  • Assignee deleted (Yuval Lifshitz)
Actions #5

Updated by Yuval Lifshitz over 2 years ago

currently when a delete marker is deleted the event that is being sent is: s3:ObjectRemoved:Delete
this is confusing since the event has no "size" or "etag" since it does not refer to a specific version of the object.

instead, we suggest adding a new event type: s3:ObjectRemoved:DeleteMarkerDeleted and use in these cases
for this event, it would be expected that the size and etag values are empty.

this would require changes the code:

in the docs: https://github.com/ceph/ceph/blob/master/doc/radosgw/s3-notification-compatibility.rst

and would require adding a new test to verify this case:
https://github.com/ceph/ceph/blob/master/src/test/rgw/bucket_notification/test_bn.py#L1942

Actions #6

Updated by Casey Bodley over 2 years ago

  • Assignee set to Yuval Lifshitz
Actions #7

Updated by Yuval Lifshitz over 1 year ago

  • Priority changed from Normal to Low
Actions #8

Updated by Yuval Lifshitz 8 months ago

this is currently working with correct timestamp
please follow the instructions here to reproduce the delete marker deletion with notifications: https://gist.github.com/yuvalif/9bf24a6c2ccba7db62f8353156ab6a21

the event type for the delete marker deletion is "ObjectRemoved:Delete".
unless specifically requested, there is no intention of adding a new event type for the delete marker deletion case

Actions #9

Updated by Yuval Lifshitz 8 months ago

  • Status changed from New to Won't Fix
  • Backport deleted (pacific)

the original issue of zero timestamp was already fixed.
no need to add a new event type

Actions

Also available in: Atom PDF