Project

General

Profile

Actions

Bug #50194

closed

librgw: make rgw file handle versioned

Added by Xuehan Xu about 3 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
% Done:

100%

Source:
Tags:
Backport:
octopus pacific quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
kcephfs
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The reason that we need this is that there could be the following scenario:

rgw_setattr sets the file attr;
rgw_write writes some new data, and encodes its attr to store into rados;
before the actual persistence of the file's attr bl, rgw_lookup loads the file's
previous attr and modifies the current file handle's metadata;
rgw_write's result persisted to rados;
rgw_setattr set the current file handle's metadata which is actually an old one to rados
In this case, the attr in rados would be out of date which means loss of data


Related issues 3 (0 open3 closed)

Copied to rgw - Backport #54083: pacific: librgw: make rgw file handle versionedResolvedCory SnyderActions
Copied to rgw - Backport #54084: quincy: librgw: make rgw file handle versionedResolvedCory SnyderActions
Copied to rgw - Backport #54085: octopus: librgw: make rgw file handle versionedResolvedCory SnyderActions
Actions #1

Updated by Casey Bodley about 3 years ago

  • Status changed from New to Fix Under Review
Actions #2

Updated by Nathan Cutler about 3 years ago

  • Backport changed from Pacific; Octopus; Nautilus to pacific, octopus, nautilus
Actions #3

Updated by Nathan Cutler about 3 years ago

@Xuehan Xu - I noticed that #50193 was created before the fix got merged into master.

Please do not create backport issues manually. They get created automatically by a bot when the master PR gets merged and this tracker's status gets changed to "Pending Backport".

Thanks!

Actions #4

Updated by Casey Bodley about 2 years ago

  • Status changed from Fix Under Review to Pending Backport
  • Backport changed from pacific, octopus, nautilus to octopus pacific quincy
Actions #5

Updated by Backport Bot about 2 years ago

  • Copied to Backport #54083: pacific: librgw: make rgw file handle versioned added
Actions #6

Updated by Backport Bot about 2 years ago

  • Copied to Backport #54084: quincy: librgw: make rgw file handle versioned added
Actions #7

Updated by Backport Bot about 2 years ago

  • Copied to Backport #54085: octopus: librgw: make rgw file handle versioned added
Actions #8

Updated by Backport Bot over 1 year ago

  • Tags set to backport_processed
Actions #9

Updated by Konstantin Shalygin over 1 year ago

  • Status changed from Pending Backport to Resolved
  • % Done changed from 0 to 100
  • Tags deleted (backport_processed)
Actions

Also available in: Atom PDF