Project

General

Profile

Fix #49896

qa: verify the benefits of mempool cacheline optimization

Added by Loïc Dachary 4 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
common
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The cacheline optimization in mempool needs testing to guard against regressions and measure how it performs.

See also the discussion on the mailing list about mempool optimization

0001-qa-verify-the-benefits-of-mempool-cacheline-optimiza.patch View (5.01 KB) Loïc Dachary, 03/19/2021 07:45 AM


Related issues

Related to RADOS - Bug #49781: unittest_mempool.check_shard_select failed Resolved

History

#1 Updated by Loïc Dachary 4 months ago

  • Related to Bug #49781: unittest_mempool.check_shard_select failed added

#2 Updated by Loïc Dachary 4 months ago

Here is how it could be done (please let me know if there is a better way):

  • Write a test program (ceph_test_c2c) that can run in two modes: with and without the optimization
  • Add a teuthology workunit in standalone part of the rados suite to do the following:
    • Run ceph_test_c2c --no-optimization
    • Run perf c2c & save the data
    • Run ceph_test c2c --with-optimization
    • Run perf c2c & save the data
    • Verify the optimized version performs at least X% better

The attached patch shows the skeleton of this test.

#3 Updated by Loïc Dachary 4 months ago

  • Description updated (diff)

#4 Updated by Loïc Dachary 3 months ago

  • Pull request ID set to 41014

#5 Updated by Loïc Dachary 3 months ago

@smithfarm, would you be so kind as to update the pull request description to reference Fixes: https://tracker.ceph.com/issues/49896 instead of Refs: https://tracker.ceph.com/issues/49781 ? My mistake :-(

I also re-pushed the commit in https://lab.fedeproxy.eu/ceph/ceph/-/tree/wip-mempool-cacheline-49781/ and it would be great if you could also push it in the pull request so the commit message is in sync.

#6 Updated by Kefu Chai 3 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF