Actions
Fix #49896
closedqa: verify the benefits of mempool cacheline optimization
% Done:
0%
Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Description
The cacheline optimization in mempool needs testing to guard against regressions and measure how it performs.
See also the discussion on the mailing list about mempool optimization
Files
Updated by Loïc Dachary about 3 years ago
- Related to Bug #49781: unittest_mempool.check_shard_select failed added
Updated by Loïc Dachary about 3 years ago
- File 0001-qa-verify-the-benefits-of-mempool-cacheline-optimiza.patch 0001-qa-verify-the-benefits-of-mempool-cacheline-optimiza.patch added
Here is how it could be done (please let me know if there is a better way):
- Write a test program (ceph_test_c2c) that can run in two modes: with and without the optimization
- Add a teuthology workunit in standalone part of the rados suite to do the following:
- Run ceph_test_c2c --no-optimization
- Run perf c2c & save the data
- Run ceph_test c2c --with-optimization
- Run perf c2c & save the data
- Verify the optimized version performs at least X% better
The attached patch shows the skeleton of this test.
Updated by Loïc Dachary almost 3 years ago
@Nathan Cutler, would you be so kind as to update the pull request description to reference Fixes: https://tracker.ceph.com/issues/49896 instead of Refs: https://tracker.ceph.com/issues/49781 ? My mistake :-(
I also re-pushed the commit in https://lab.fedeproxy.eu/ceph/ceph/-/tree/wip-mempool-cacheline-49781/ and it would be great if you could also push it in the pull request so the commit message is in sync.
Updated by Kefu Chai almost 3 years ago
- Status changed from In Progress to Resolved
Actions