Cleanup #49220
Tasks #49211: mgr/dashboard: accessibility, performance and security check for dashboard
mgr/dashboard: avoid using document.write()
% Done:
0%
Tags:
Backport:
pacific,octopus,nautilus
Reviewed:
Affected Versions:
Pull request ID:
Description
For users on slow connections, external scripts dynamically injected via `document.write()` can delay page load by tens of seconds. https://developers.google.com/web/updates/2016/08/removing-document-write
Related issues
History
#1 Updated by Avan Thakkar over 2 years ago
- Pull request ID set to 39372
#2 Updated by Ernesto Puerta over 2 years ago
Nice suggestion too! Chrome is always complaining about the use of document.write(). However that part of code was autogenerated by Angular. Perhaps is it time to regenerate the index.html?
#3 Updated by Ernesto Puerta over 2 years ago
- Tracker changed from Tasks to Cleanup
- Status changed from In Progress to Fix Under Review
- Backport set to pacific,octopus,nautilus
Given this has a positive impact on page load speed, added backports.
#4 Updated by Ernesto Puerta over 2 years ago
- Status changed from Fix Under Review to Pending Backport
#5 Updated by Backport Bot over 2 years ago
- Copied to Backport #49326: pacific: mgr/dashboard: avoid using document.write() added
#6 Updated by Backport Bot over 2 years ago
- Copied to Backport #49327: nautilus: mgr/dashboard: avoid using document.write() added
#7 Updated by Backport Bot over 2 years ago
- Copied to Backport #49328: octopus: mgr/dashboard: avoid using document.write() added
#8 Updated by Ernesto Puerta over 2 years ago
- Status changed from Pending Backport to Resolved
#9 Updated by Ernesto Puerta about 2 years ago
- Precedes Cleanup #50655: mgr/dashboard: dashboard not working with a URL prefix added