Project

General

Profile

Actions

Bug #4829

closed

client: handling part of MClientForward incorrectly?

Added by Greg Farnum about 11 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
High
Assignee:
-
Category:
-
Target version:
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Client
Labels (FS):
multimds
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

(In reference to a backwards check for is_replay when doing encode_cap_releases())

Greg
isn't that backwards?
only encoding the releases if we got an unsafe reply?

Sage Weil
argh
btw i suspect this is also wrong wrt forwards

Greg
backwards logic?
I haven't seen your patches for it yet

Sage Weil
fixed that
i mean, i think we only want to do this the first attempt for the request, not each time we forward.
but that needs a careful look at handling for the MClientForward stuff
like, that swap() obviously will only work the first time around.. but the other encode_cap_releases() will do it each tie
time
so at the very least its slightly wrong

Actions

Also available in: Atom PDF