Project

General

Profile

Actions
Copy link

Bug #48245

closed

mgr/dashboard: SMART data routine raises an exception

Added by Kiefer Chang over 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Kiefer Chang
Category:
Component - OSDs
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
Ceph - v16.0.0
ceph-qa-suite:
Pull request ID:
38163
Crash signature (v1):
Crash signature (v2):

Description

Please check the code: https://github.com/ceph/ceph/blob/b637909a9153a419511f943e4eee7800ad3bbb99/src/pybind/mgr/dashboard/services/ceph_service.py#L304-L308
The daemon_id is a string. This causes an exception in the logging call.

            msg = '[SMART] could not retrieve device list from daemon with type %s and ' +\
                'with ID %d'
            logger.debug(msg, daemon_type, daemon_id)

This was spotted when reviewing this backport PR: https://github.com/ceph/ceph/pull/37972
I would suggest including a fix to the backport and create a new PR to fix the issue in master.

Related issues 1 (0 open — 1 closed)

Copied to Dashboard - Backport #48500: octopus: mgr/dashboard: SMART data routine raises an exceptionResolvedLaura PaduanoActions
Actions
Copy link
 #1

Updated by Kiefer Chang over 3 years ago

  • Status changed from New to In Progress
  • Assignee set to Kiefer Chang
Actions
Copy link
 #2

Updated by Kiefer Chang over 3 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 38163
Actions
Copy link
 #3

Updated by Ernesto Puerta over 3 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #4

Updated by Nathan Cutler over 3 years ago

  • Backport set to octopus
Actions
Copy link
 #5

Updated by Nathan Cutler over 3 years ago

  • Copied to Backport #48500: octopus: mgr/dashboard: SMART data routine raises an exception added
Actions
Copy link
 #6

Updated by Loïc Dachary about 3 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link
 #7

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 138 to Component - OSDs
Actions
Copy link

Also available in: Atom PDF