Project

General

Profile

Bug #48245

mgr/dashboard: SMART data routine raises an exception

Added by Kiefer Chang 2 months ago. Updated about 1 month ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
Category:
dashboard/osds
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

Please check the code: https://github.com/ceph/ceph/blob/b637909a9153a419511f943e4eee7800ad3bbb99/src/pybind/mgr/dashboard/services/ceph_service.py#L304-L308
The daemon_id is a string. This causes an exception in the logging call.

            msg = '[SMART] could not retrieve device list from daemon with type %s and ' +\
                'with ID %d'
            logger.debug(msg, daemon_type, daemon_id)

This was spotted when reviewing this backport PR: https://github.com/ceph/ceph/pull/37972
I would suggest including a fix to the backport and create a new PR to fix the issue in master.


Related issues

Copied to mgr - Backport #48500: octopus: mgr/dashboard: SMART data routine raises an exception In Progress

History

#1 Updated by Kiefer Chang 2 months ago

  • Status changed from New to In Progress
  • Assignee set to Kiefer Chang

#2 Updated by Kiefer Chang 2 months ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 38163

#3 Updated by Ernesto Puerta about 2 months ago

  • Status changed from Fix Under Review to Pending Backport

#4 Updated by Nathan Cutler about 1 month ago

  • Backport set to octopus

#5 Updated by Nathan Cutler about 1 month ago

  • Copied to Backport #48500: octopus: mgr/dashboard: SMART data routine raises an exception added

Also available in: Atom PDF