Project

General

Profile

Actions
Copy link

Cleanup #48055

closed

mgr/telemetry: enable static type checks

Added by Ernesto Puerta over 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Kefu Chai
Category:
telemetry module
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:
39186

Description

Enable mypy (mgr/tox.ini) for this module and fix detected errors.

Actions
Copy link
 #1

Updated by Kefu Chai over 3 years ago

  • Status changed from New to Fix Under Review
  • Assignee set to Kefu Chai
  • Pull request ID set to 39186
Actions
Copy link
 #2

Updated by Kefu Chai over 3 years ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link
 #3

Updated by Yaarit Hatuka about 3 years ago

Just for reference, if we decide to backport this, we need to make sure to include this typo fix:
https://github.com/ceph/ceph/pull/39538/commits/eb3b27c8da741ff7b325eb7ac8bd85dd10b97994

Actions
Copy link
 #4

Updated by Nathan Cutler about 3 years ago

Yaarit Hatuka wrote:

Just for reference, if we decide to backport this, we need to make sure to include this typo fix:
https://github.com/ceph/ceph/pull/39538/commits/eb3b27c8da741ff7b325eb7ac8bd85dd10b97994

If the backport PR get created blindly via ceph-backport.sh, then it's likely this will be overlooked. Just sayin'...

Actions
Copy link

Also available in: Atom PDF