Project

General

Profile

Actions
Copy link

Cleanup #47355

closed

mgr/dashboard: create directive for AuthStorage service

Added by Ernesto Puerta over 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Ngwa Sedrick Meh
Category:
Security & Auth
Target version:
Ceph - v17.0.0
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:
41034

Description

Right now, if a component wants to conditionally display its elements based on authorization/scopes criteria, it has to embed direct calls to the AuthService. That basically causes a tight coupling between components and the AuthStorage API (localStorage based).

By using a simple directive, we can move all references to AuthStorage to the HTML template, leave a cleaner component logic (no intermixed AuthStorage calls), and simplify unit tests (no need of 'mocking' auth/localstorage, just a directive).

Actions
Copy link

Also available in: Atom PDF