Project

General

Profile

Cleanup #47355

mgr/dashboard: create directive for AuthStorage service

Added by Ernesto Puerta about 1 year ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Category:
Security & Auth
Target version:
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Right now, if a component wants to conditionally display its elements based on authorization/scopes criteria, it has to embed direct calls to the AuthService. That basically causes a tight coupling between components and the AuthStorage API (localStorage based).

By using a simple directive, we can move all references to AuthStorage to the HTML template, leave a cleaner component logic (no intermixed AuthStorage calls), and simplify unit tests (no need of 'mocking' auth/localstorage, just a directive).

History

#1 Updated by Ernesto Puerta 7 months ago

  • Tags set to low-hanging-fruit

#2 Updated by Ernesto Puerta 5 months ago

  • Project changed from mgr to Dashboard
  • Category changed from 145 to Security & Auth

#3 Updated by Ngwa Sedrick Meh 5 months ago

Hi, How can we resolve this?

#4 Updated by Ngwa Sedrick Meh 5 months ago

  • Pull request ID set to 41034

#5 Updated by Alfonso Martínez 3 months ago

  • Status changed from New to Fix Under Review
  • Assignee set to Ngwa Sedrick Meh
  • Target version changed from v16.0.0 to v17.0.0

#6 Updated by Ernesto Puerta 2 months ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF