Project

General

Profile

Actions
Copy link

Cleanup #468

closed

mds: use enum for LOCK_* in mds/locks.h

Added by Sage Weil over 13 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Colin McCabe
Category:
-
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Component(FS):
Labels (FS):
Pull request ID:

Description

We just fixed a bug that (I think?) the compiler would have warned about.. in->get_state() LOCK_MIX instead of lock->get_state() LOCK_MIX.

Although keep in mind the SimpleLock state member has a specific number of bits so that it encodes properly (and aligns efficiently?). Maybe get_state() should cast the return value to a lock_state_t or something?

Actions
Copy link

Also available in: Atom PDF