Project

General

Profile

Actions

Bug #46208

closed

Update to boost 1.73 (fix context support for IBM Z)

Added by Ulrich Weigand almost 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Boost version 1.73 now provides working support for boost::context (and therefore coroutines) on the Linux on IBM Z (s390x) platform.

Note that 1.72 already had some code to support contexts on IBM Z, but this was actually broken.
This was fixed via: https://github.com/boostorg/context/pull/133

However, Ceph is still bundling 1.72 (with broken support). Would it be possible to upgrade to 1.73 instead?

Actions #1

Updated by Kefu Chai almost 4 years ago

  • Status changed from New to Fix Under Review
  • Assignee set to Kefu Chai
  • Pull request ID set to 35787
Actions #2

Updated by Kefu Chai almost 4 years ago

  • Status changed from Fix Under Review to Resolved
Actions #3

Updated by Ken Dreyer almost 4 years ago

Kefu, can we backport this change to Octopus and Nautilus? This will help us avoid carrying a Boost patch downstream.

Actions #4

Updated by Jason Dillaman almost 4 years ago

Ken Dreyer wrote:

Kefu, can we backport this change to Octopus and Nautilus? This will help us avoid carrying a Boost patch downstream.

Just my two cents, but that seems like a much higher risk than just two small patches that are unique to s390x, right?

Actions #5

Updated by Nathan Cutler almost 4 years ago

The Jenkins "make check" check in nautilus PRs seems to already be using Boost 1.73 (!)

https://github.com/ceph/ceph/pull/35686

Actions #6

Updated by David Galloway over 3 years ago

Does this mean our chacra libboost repos should be removed from Jenkins builders? See https://github.com/ceph/ceph/pull/37972#issuecomment-741030327

EDIT: Or maybe this needs to be backported to Octopus (at least)?

Actions

Also available in: Atom PDF