Project

General

Profile

Actions

Cleanup #45322

closed

mgr: simplify 'module ls' output

Added by Ernesto Puerta about 4 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
ceph-mgr
Target version:
% Done:

0%

Tags:
Backport:
nautilus, octopus
Reviewed:
Affected Versions:
Pull request ID:

Description

Before PR https://github.com/ceph/ceph/pull/19235, ceph mgr module ls simply printed a short list of available and enabled modules that easily fit into the screen height.

However, after that PR, the output includes lots of metadata for disable modules, which makes hard to understand which modules are always on, available/disabled:

{
    "always_on_modules": [
        "balancer",
        "crash",
        "devicehealth",
        "orchestrator",
        "osd_support",
        "pg_autoscaler",
        "progress",
        "rbd_support",
        "status",
        "telemetry",
        "volumes" 
    ],
    "enabled_modules": [
        "cli",
        "dashboard",
        "iostat",
        "prometheus",
        "restful" 
    ],
    "disabled_modules": [
        {
            "name": "alerts",
            "can_run": true,
            "error_string": "",
            "module_options": {
                "interval": {
                    "name": "interval",
                    "type": "secs",
                    "level": "advanced",
                    "flags": 1,
                    "default_value": "60",
                    "min": "",
                    "max": "",
                    "enum_allowed": [],
                    "desc": "How frequently to reexamine health status",
                    "long_desc": "",
                    "tags": [],
                    "see_also": []
                },
                "log_level": {
...

A suggestion would be to only dump that metadata if 'detail' option is present (similar to other ceph commands).

Actions #1

Updated by Laura Flores over 2 years ago

  • Status changed from New to In Progress
  • Assignee set to Laura Flores
Actions #2

Updated by Laura Flores over 2 years ago

  • Pull request ID set to 43411
Actions #3

Updated by Laura Flores over 2 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF