Actions
Bug #45253
openInconsistent characters allowed set for device classes
Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:
0%
Source:
Tags:
low-hanging-fruit
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
I changed the device class of a number of disks yesterday successfully to "rbd.meta":
[root@gnosis ~]# ceph osd crush tree | grep rbd.meta 37 rbd.meta 0.36400 osd.37 48 rbd.meta 0.36400 osd.48 36 rbd.meta 0.36400 osd.36 ...
I was also able to set a device-class filter rule for configs:
[root@gnosis ~]# ceph config dump ... osd class:rbd.meta basic osd_memory_target 4294967296 ...
However, a "ceph osd crush class ls-osd rbd.meta" fails with an invalid character error:
[root@gnosis ~]# ceph osd crush class ls-osd rbd.meta Invalid command: invalid chars . in rbd.meta osd crush class ls-osd <class> : list all osds belonging to the specific <class> Error EINVAL: invalid command
I think "." sounds like a reasonable character to allow.
- Please fix this to be consistent throughout all device-class commands.
- For being able to continue to work: should I change the character or is "." legal? This question is urgent, I would like to keep the dot and am stuck right now.
Actions